Apply correct hierarchy and IDs to Minitest spec items #3501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were incorrectly creating the test hierarchy for Minitest specs. First, we weren't handling the nesting correctly for classes.
Second, we were not properly matching what Minitest does if you decide to create a test group using a class inside a describe. In this scenario, Minitest does not use the describe's description as part of the resulting group ID. For example:
The correct ID for the inner spec group is
MySpec::InnerSpec
and notMySpec::something::InnerSpec
.Implementation
I started using a flat stack of group IDs that differentiate between a class group or a describe group, so that we can do the right thing depending on what we find.
Automated Tests
Added tests.