Skip to content

Use a number regex for running spec examples #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented May 21, 2025

Motivation

Since we cannot guarantee that we will discover spec examples at the exact order Minitest will (because of the runtime vs static analysis difference), we use line numbers to ensure that the discovery and result reporting IDs will match.

However, for running the tests, we cannot use the line number information as that may not match the spec ID Minitest has assigned to that particular example. We can fix that by substituting that part of the command for a regex.

Implementation

Minitest formats the spec count with 4 digits, so I started replacing the test_XXXX for the regex test_\d{4}. Note that this is still specific enough to run the right tests since we include the group's name and the rest of the example name.

Automated Tests

Updated our tests.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock self-assigned this May 21, 2025
@vinistock vinistock added server This pull request should be included in the server gem's release notes bugfix This PR will fix an existing bug labels May 21, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review May 21, 2025 12:38
@vinistock vinistock requested a review from a team as a code owner May 21, 2025 12:38
@vinistock vinistock merged commit 69ae1d2 into main May 21, 2025
44 checks passed
@vinistock vinistock deleted the 05-21-use_a_number_regex_for_running_spec_examples branch May 21, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants