Skip to content

Fix upcoming RBS breaking changes #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented May 21, 2025

Motivation

Spoom started depending on the development version of RBS, which means Tapioca also will. We need to relax our RBS constraint or else we won't be able to install the LSP automatically since no version will satisfy the constraints.

Implementation

  1. Updated the constraint
  2. Upgraded the gem to the latest dev version
  3. Fixed a minor breaking change where the buffer name started returning a Pathname instead of a String

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock self-assigned this May 21, 2025
@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels May 21, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review May 21, 2025 19:19
@vinistock vinistock requested a review from a team as a code owner May 21, 2025 19:19
@vinistock vinistock force-pushed the 05-21-fix_upcoming_rbs_breaking_changes branch from 111f93b to f32fd6b Compare May 21, 2025 19:31
@vinistock vinistock enabled auto-merge (squash) May 21, 2025 19:42
@vinistock vinistock merged commit 2c388bf into main May 21, 2025
45 checks passed
@vinistock vinistock deleted the 05-21-fix_upcoming_rbs_breaking_changes branch May 21, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants