Avoid shitfting editor focus when using test code lens #3527
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
05-22-avoid_shitfting_editor_focus_when_using_test_code_lens
branch
from
b849725 to
4449b7c
Compare
|
I'd consider this as a bug fix btw. |
|
Since it's a design decision, not a crash or definitively incorrect behaviour, I think it'd keep it as |
vinistock
deleted the
05-22-avoid_shitfting_editor_focus_when_using_test_code_lens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We received feedback from users that the shifting of editor focus when running a test in the terminal via code lens is surprising and not the desired behaviour. Let's prevent the focus from changing and let people manually expand the explorer if desired.
I still kept the focus change for when someone uses the
Runcode lens. I think that's sensible since the user will probably want to see the test results and those will only show up there.