Skip to content

add mise install path for apt installations #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

jtannas
Copy link
Contributor

@jtannas jtannas commented May 23, 2025

Motivation

Closes #3531 (LSP fails to detect mise that is installed via apt into /usr/bin/mise)

Implementation

Followed pattern laid out in #2943 for multiple install locations.

Automated Tests

No tests added since #2943 has none that I could use as a starting point to follow.

Manual Tests

Follow the reproduction steps in #3531 to see if the problem has been resolved.

@jtannas jtannas requested a review from a team as a code owner May 23, 2025 17:50
Copy link

graphite-app bot commented May 23, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@jtannas
Copy link
Contributor Author

jtannas commented May 23, 2025

I have signed the CLA!

@vinistock vinistock added vscode This pull request should be included in the VS Code extension's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Jun 2, 2025
@vinistock
Copy link
Member

Thanks for the PR! The code looks good, but there are some styling issues. You can automatically fix those by running yarn run format inside the vscode directory.

@jtannas
Copy link
Contributor Author

jtannas commented Jun 2, 2025

Thanks for the PR! The code looks good, but there are some styling issues. You can automatically fix those by running yarn run format inside the vscode directory.

Thanks for running the workflows and catching that 🙇
The PR has been updated with the formatting fix.

Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vinistock vinistock merged commit 8662998 into Shopify:main Jun 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP fails to detect mise that is installed via apt into /usr/bin/mise
2 participants