Move all abstract methods to RBS syntax #3534
Merged
+52
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
Morriar
approved these changes
May 23, 2025
vinistock
force-pushed
the
05-09-move_all_abstract_methods_to_shims
branch
from
e1f5e19 to
7d3c290
Compare
Morriar
reviewed
May 23, 2025
vinistock
force-pushed
the
05-09-move_all_abstract_methods_to_shims
branch
2 times, most recently
from
c96450e to
5b0ef46
Compare
vinistock
force-pushed
the
05-09-move_all_abstract_methods_to_shims
branch
from
5b0ef46 to
96e8d99
Compare
vinistock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR moves all abstract methods to RBIs, which is the second to last step needed to remove the dependency on
sorbet-runtime.Implementation
Moved all abstract things to RBIs.