Index attr
#3544
Merged
Index attr
#3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
alexcrocha
approved these changes
Jun 2, 2025
Morriar
reviewed
Jun 3, 2025
| @@ -254,7 +254,7 @@ def on_call_node_enter(node) | |||
| case message | |||
| when :private_constant | |||
| handle_private_constant(node) | |||
| when :attr_reader | |||
| when :attr_reader, :attr | |||
There was a problem hiding this comment.
I think you can also do attr :bar, true to make it an attr_writer
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
### Motivation As pointed out in #3544 (comment), `attr` actually accepts a boolean argument to determine if a writer is defined or not. ### Implementation Started handling the argument in a separate branch for `attr`. ### Automated Tests Improved our existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we added attribute indexing, we forgot to consider
attr, which is an alias toattr_reader.Implementation
Added
attrin the same branch asattr_reader.Automated Tests
Added a test.