feat: register profile command #3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxveldink
force-pushed
the
05-29-feat_register_profile_command
branch
2 times, most recently
from
91df651 to
7f1e21a
Compare
maxveldink
force-pushed
the
05-29-feat_register_profile_command
branch
from
7f1e21a to
3efc9c6
Compare
maxveldink
force-pushed
the
05-29-feat_register_profile_command
branch
from
3efc9c6 to
013151a
Compare
maxveldink
force-pushed
the
05-29-feat_register_profile_command
branch
from
45818da to
01070cd
Compare
maxveldink
added
the
vscode
maxveldink
force-pushed
the
05-29-feat_register_profile_command
branch
from
01070cd to
44f5123
Compare
maxveldink
commented
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2273
Requires this Vernier PR to ship and a new version to be released. ✅
This adds a way to profile the currently open file using Vernier, and display the output in editor (VSCode will also display numbers inline with the file).
Implementation
Registers a command that uses Vernier under the hood with the active file and open the
.cpuprofilefile.Automated Tests
Since this was a straightforward command and I didn't see tests for similar commands, I opted to not add a test here. Happy to extract this to a function and test it if we'd prefer to do so.
Manual Tests
Profile current filecommand (either from the palette or editor menu of active file).cpuprofileopen. When you click back to the profiled file, VSCode should automatically annotate lines with perf information.ProfileCurrentFileDemo.mov