Update collect_references to use Prism::LexResult
#3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3252, `RubyDocument#parse_result` becomes `Prism::ParseLexResult`, which's `value` is an array instead of a single node. And we forgot to update `collect_references` to account for this change because the codepath was not covered in the test. So this commit adds a test for the codepath and updates `collect_references` to use `Prism::LexResult`.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
st0012
added
the
server
Morriar
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3252,
RubyDocument#parse_resultbecomesPrism::ParseLexResult, which'svalueis an array instead of a single node. And we forgot to updatecollect_referencesto account for this change because the codepath was not covered in the test.So this commit adds a test for the codepath and updates
collect_referencesto usePrism::LexResult.Implementation
Automated Tests
Manual Tests