move @graphql-codegen/* to devdeps #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@graphql-codegen/cli and friends are super useful as tooling, but they also depend on the world: https://npmgraph.js.org/?q=%40shopify%2Fshopify_function Just @graphql-codegen/cli and its transitive dependencies add 211 maintainers to your supply chain: https://npmgraph.js.org/?q=%40graphql-codegen%2Fcli It also creates noise re: CVE spam in a long tail of dependent packages. As far as I can tell, there's no runtime dependency on any of these packages -- so we can freely move them to dev dependencies.
draaglom
force-pushed
the
draaglom/move-codegen-to-devdeps
branch
from
954a5e5 to
641311f
Compare
|
@saulecabrera sorry for the @ but I guess you're the main maintainer :-) can you let me know if I've misunderstood something re: a dependency on these packages (e.g. a build step I can't see?) or if this change is otherwise not valuable? (For clarity, I'm aware that typical users of this package will also depend on Thanks! |
jacobsteves
approved these changes
Sep 23, 2024
|
thanks for the review/merge @jacobsteves ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graphql-codegen/cli and friends are super useful as tooling, but they
also depend on the world:
https://npmgraph.js.org/?q=%40shopify%2Fshopify_function
Just @graphql-codegen/cli and its transitive dependencies add 211
maintainers to your supply chain when using
@shopify/shopify_function:https://npmgraph.js.org/?q=%40graphql-codegen%2Fcli
It also creates noise for consuming apps re: CVE spam in a long tail of transitive dependencies.
As far as I can tell, there's no runtime dependency on any of these
packages -- so we can freely move them to dev dependencies.