Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

[core] Rename the ConstraintSetBase template class to ConstraintSetTpl #110

Conversation

ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Oct 5, 2024

This PR renames the template class to something more appropriate, with appropriate deprecations and deprecated typedefs.

  • the context typedef "ConstraintSetBase" to "ConstraintSet"
  • perform similar op to the related header (now constraint-set.hpp), deprecate headerconstraint-base.hpp
  • add deprecated typedefs to keep the previous behaviour valid

@ManifoldFR ManifoldFR requested a review from jorisv October 5, 2024 11:33
@ManifoldFR ManifoldFR force-pushed the topic/rename-constraint-base-to-constraint-set branch from 23407ee to 8d4a15f Compare October 9, 2024 21:03
@ManifoldFR ManifoldFR requested a review from edantec October 9, 2024 21:03
… the context typedef "ConstraintSetBase" to "ConstraintSet"

+ perform similar op to the related header, add header deprecation for constraint-base.hpp
+ add deprecated typedefs for the previous behaviour
@ManifoldFR ManifoldFR force-pushed the topic/rename-constraint-base-to-constraint-set branch from 8d4a15f to 6610152 Compare October 9, 2024 21:05
@ManifoldFR ManifoldFR enabled auto-merge October 10, 2024 13:24
Copy link
Collaborator

@edantec edantec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamped

@ManifoldFR ManifoldFR merged commit 8407d73 into Simple-Robotics:devel Oct 10, 2024
24 checks passed
@ManifoldFR ManifoldFR deleted the topic/rename-constraint-base-to-constraint-set branch October 10, 2024 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants