Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

[prox-solver] deprecate getters for workspace and results in solver #76

Merged
merged 5 commits into from
May 1, 2024

Conversation

ManifoldFR
Copy link
Member

@ManifoldFR ManifoldFR commented Apr 30, 2024

  • deprecate getWorkspace() and getResults() in both C++ and Python
  • use eigenpy 3.4 unique_ptr support to expose to Python
  • bump eigenpy minimum required version to 3.4

@ManifoldFR ManifoldFR changed the title [prox-solver] remove getters for workspace and results in solver, use eigenpy 3.4 unique_ptr support [prox-solver] deprecate getters for workspace and results in solver Apr 30, 2024
@ManifoldFR ManifoldFR enabled auto-merge (rebase) April 30, 2024 18:09
@ManifoldFR ManifoldFR force-pushed the topic/solver-unique-ptr-no-getter branch 3 times, most recently from 5d4a936 to 83709a2 Compare April 30, 2024 20:18
… 3.4 unique_ptr call policy

+ add deprecation_policy.hpp header (backport from eigenpy)
@ManifoldFR ManifoldFR force-pushed the topic/solver-unique-ptr-no-getter branch from 83709a2 to be5a3e1 Compare April 30, 2024 21:20
@ManifoldFR ManifoldFR disabled auto-merge May 1, 2024 07:53
@ManifoldFR ManifoldFR merged commit b44b256 into devel May 1, 2024
@ManifoldFR ManifoldFR deleted the topic/solver-unique-ptr-no-getter branch May 1, 2024 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant