Reference ImageSharp V2 preview #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 85.28% 85.53% +0.25%
==========================================
Files 54 54
Lines 1529 1549 +20
Branches 228 231 +3
==========================================
+ Hits 1304 1325 +21
+ Misses 169 167 -2
- Partials 56 57 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
antonfirsov
reviewed
Jan 17, 2022
|
|
||
| if (image.Format is JpegFormat) | ||
| { | ||
| var reference = |
There was a problem hiding this comment.
Absolutely minor idea, but maybe we can shall make the codecs deep-cloneable one day. It's a good community-contribution candidate.
There was a problem hiding this comment.
I was thinking the exact same thing while I was writing this! 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Add a reference to the ImageSharp V2 preview so we can dogfood changes. Bumps Major version to V2 due to breaking changes