Skip to content

Initial Permission Support #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Initial Permission Support #164

merged 3 commits into from
Sep 11, 2023

Conversation

cryptoAlgorithm
Copy link
Member

Swiftcord will now respect channel visibility permissions (including role perms and overrides). Previously, channels that the user had no permission to view were still visible in the channel list, but would of course cause errors when those channels are entered.

Xref #26

@cryptoAlgorithm cryptoAlgorithm added enhancement New feature or request ui User interface-related issues backend Behind-the-scenes code related issues labels Jul 1, 2023
@cryptoAlgorithm cryptoAlgorithm self-assigned this Jul 1, 2023
@cryptoAlgorithm cryptoAlgorithm linked an issue Jul 1, 2023 that may be closed by this pull request
@cryptoAlgorithm cryptoAlgorithm marked this pull request as ready for review September 11, 2023 12:10
@cryptoAlgorithm
Copy link
Member Author

This is now ready for preview. It currently only respects channel visibility permissions, but the user/role permission merging logic has been completed.

@cryptoAlgorithm cryptoAlgorithm added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 2fac042 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Behind-the-scenes code related issues enhancement New feature or request ui User interface-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Permissions
1 participant