Skip to content

Update & fix build of ruTorrent #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 13, 2020
Merged

Update & fix build of ruTorrent #4209

merged 21 commits into from
Oct 13, 2020

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Oct 7, 2020 •
edited
Loading

Motivation: Fed-up of seeing this package fail to build under github-action so this is a first trial at fixing things up and while at it updating the code base.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

IMPORTANT NOTES

@th0ma7 th0ma7 self-assigned this Oct 7, 2020
This was referenced Oct 7, 2020
Merged
Closed
@ymartin59
Copy link
Contributor

@th0ma7 You may inspire from this closed PR #3175 from @Safihre

@ymartin59
Copy link
Contributor

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

@ymartin59
Copy link
Contributor

I propose to submit our "cross-compiling" patches upstream if relevant to ease future maintenance/update

@th0ma7 th0ma7 mentioned this pull request Oct 10, 2020
Open
@th0ma7
Copy link
Contributor Author

th0ma7 commented Oct 10, 2020

I propose to submit our "cross-compiling" patches upstream if relevant to ease future maintenance/update

Excellent point, done.

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

I'll see what I can do but really this was an easy no maintenance workaround... I'd rather just sticking to that solution as it may be useful elsewhere as well.

@th0ma7 th0ma7 changed the title [wip] Update to ruTorrent Update & fix build of ruTorrent Oct 10, 2020
@th0ma7 th0ma7 mentioned this pull request Oct 12, 2020
Closed
th0ma7 added 19 commits October 12, 2020 20:13
@th0ma7
cppunit: Add new dependency for rtorrent
656d0e2
@th0ma7
libtorrent: Update from version 0.13.6 to 0.13.8
cb7a48d
@th0ma7
xmlrpc-c: Update from version 1.39.07 to 1.51.06
251ddbf
@th0ma7
rtorrent: Update from version 0.9.6 to 0.9.8
c1a1f25
@th0ma7
ruTorrent: Update from version 3.8 to 3.10
d604428
@th0ma7
ruTorrent: Update from version 3.8 to 3.10
330323e
@th0ma7
mediainfo: Update from 20.03 to 20.08
44639d6
@th0ma7
libmediainfo: Update from version 19.09 to 20.08
0930ccf
@th0ma7
libzen: Update from version 0.4.37 to 0.4.38
5918398
@th0ma7
unzip: Change download URL to https and sourceforge
fc676b6
@th0ma7
cppunit: Adjust PLIST
8b286c4
@th0ma7
xmlrpc-c: Fix PLIST for libxmlrpc_util.so.4.51
18e8d15
@th0ma7
mediainfo: Update spk version to 20.08
1ab56f0
@th0ma7
rutorrent: Bump spk revision number to 3
ca78994
@th0ma7
rutorrent: Mark hi3535 as unsupported due to compiler segfault
64d28f3
@th0ma7
libsigc++: Mark 88f6281 as unsupported due to lacking c++11
8a1e967
@th0ma7
rtorrent: Mark hi3535 arch as unsupported due to compiler segfault
3c60b88
@th0ma7
libsigc++: Revert marking 88f6281 as unsupported (PR SynoCommunity#4010)
8a59dcd
@th0ma7
rtorrent: switch to ncursesw
e0b18c1
@th0ma7
Copy link
Contributor Author

th0ma7 commented Oct 12, 2020 •
edited
Loading

I do not agree to include "cppunit" just to get source code application built. Please find a switch to disable test cases compilation/exection, or if lacking, create one.

@ymartin59 I've quickly check and to my understanding cppunit checks are mandatory to get the rtorrent to build

I suggest we merge as-is for now until another solution is found... other solution would be to add cppunit to the docker image ans part of the Debian image howto procedure...

ymartin59
ymartin59 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so you can merge with cppunit

@th0ma7 th0ma7 merged commit 9de705e into SynoCommunity:master Oct 13, 2020
@th0ma7 th0ma7 deleted the rtorrent branch October 13, 2020 00:18
@publicarray publicarray mentioned this pull request Oct 13, 2020
Closed
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
@th0ma7
Update & fix build of ruTorrent (SynoCommunity#4209)
9ee5175 
* cppunit: Add new dependency for rtorrent

* libtorrent: Update from version 0.13.6 to 0.13.8

* xmlrpc-c: Update from version 1.39.07 to 1.51.06

* rtorrent: Update from version 0.9.6 to 0.9.8

* rtorrent: switch to ncursesw

* rutorrent: Mark hi3535 as unsupported due to compiler segfault

* ruTorrent: Update from version 3.8 to 3.10

* ruTorrent: Mark ARM5 and PPC arches as unsupported

* mediainfo: Update from 20.03 to 20.08

* libmediainfo: Update from version 19.09 to 20.08

* libzen: Update from version 0.4.37 to 0.4.38

* unzip: Change download URL to https and sourceforge

* libsigc++: Mark 88f6281 as unsupported due to lacking c++11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 approved these changes

Assignees

@th0ma7 th0ma7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@th0ma7 @ymartin59 @hgy59