ihp: update to v1.3.1 #9594
Merged
ihp: update to v1.3.1 #9594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This took 23 minutes to build and run verification for me locally... what in the world is going on here? For context, this passed verification but I have a hard time wanting to continue implementations that take half an hour to run. |
|
Okay, ate lunch and talked this over with Nate - it's already in and other frameworks already take this much or longer to run. LGTM |
|
Thanks for your feedback 👍 you're right that it takes far to long. I'll look into how we can further optimize this to get the build time down. IMO it should be possible in 2 - 3 min instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the IHP framework from v.1.0.1 to v1.3.1
This fixes the test failure here https://tfb-status.techempower.com/results/91a66052-9d86-446c-b31a-eadbd669ed08