Skip to content

Make jwt::decoded_jwt moveable #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/jwt-cpp/jwt.h
Original file line number Diff line number Diff line change
Expand Up @@ -2530,7 +2530,7 @@ namespace jwt {
class decoded_jwt : public header<json_traits>, public payload<json_traits> {
protected:
/// Unmodifed token, as passed to constructor
const typename json_traits::string_type token;
typename json_traits::string_type token;
/// Header part decoded from base64
typename json_traits::string_type header;
/// Unmodified header part in base64
Expand Down
26 changes: 26 additions & 0 deletions tests/TokenTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -774,3 +774,29 @@ TEST(TokenTest, ThrowInvalidKeyLength) {
ASSERT_NO_THROW(jwt::algorithm::es384(ecdsa384_pub_key, ecdsa384_priv_key));
ASSERT_NO_THROW(jwt::algorithm::es512(ecdsa521_pub_key, ecdsa521_priv_key));
}

TEST(TokenTest, MoveDecodedToken) {
std::string token0 = "eyJhbGciOiJub25lIiwidHlwIjoiSldTIn0.eyJpc3MiOiJhdXRoMCJ9.";
std::string token1 =
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXUyJ9.eyJpc3MiOiJhdXRoMCJ9.AbIJTDMFc7yUa5MhvcP03nJPyCPzZtQcGEp-zWfOkEE";
auto decoded_token0 = jwt::decode(token0);
auto decoded_token1 = jwt::decode(token1);
decoded_token0 = std::move(decoded_token1);
ASSERT_EQ(token1, decoded_token0.get_token());

ASSERT_TRUE(decoded_token0.has_algorithm());
ASSERT_TRUE(decoded_token0.has_type());
ASSERT_FALSE(decoded_token0.has_content_type());
ASSERT_FALSE(decoded_token0.has_key_id());
ASSERT_TRUE(decoded_token0.has_issuer());
ASSERT_FALSE(decoded_token0.has_subject());
ASSERT_FALSE(decoded_token0.has_audience());
ASSERT_FALSE(decoded_token0.has_expires_at());
ASSERT_FALSE(decoded_token0.has_not_before());
ASSERT_FALSE(decoded_token0.has_issued_at());
ASSERT_FALSE(decoded_token0.has_id());

ASSERT_EQ("HS256", decoded_token0.get_algorithm());
ASSERT_EQ("JWS", decoded_token0.get_type());
ASSERT_EQ("auth0", decoded_token0.get_issuer());
}