feat: add response.data and fix styling for layout with download zip … #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae94
reviewed
Oct 16, 2024
| @@ -56,7 +56,7 @@ export function downloadZip(toggleNotification, formatMessage, post, get) { | |||
| return async function(dispatch) { | |||
| dispatch(setLoadingState(true)); | |||
| try { | |||
| const { message, base64Data, name } = await get('/config-sync/zip'); | |||
| const { message, base64Data, name } = (await get('/config-sync/zip')).data; | |||
There was a problem hiding this comment.
Good catch! Wasnt aware of this implementation, and couldn't test on Strapi v5. Thanks!
ae94
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…button
What does it do?
Add some styling for the layout in the config sync
Add destructurering on data
Why is it needed?
For downloading the zip file and layout.
How to test it?
Download the file
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request