-
Notifications
You must be signed in to change notification settings - Fork 1
chore(hmr): add initial hot-module-replacement example #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the missing semicolons and I'll merge this in :)
module.hot.accept('./library', function() { | ||
console.log('Accepting the updated library module!'); | ||
Library.log(); | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ;
export default { | ||
log() { | ||
// Change this after the server is started to test | ||
console.log('First log...') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ;
// Change this after the server is started to test | ||
console.log('First log...') | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ;
I had this one sitting around too -- it'll probably need some work to synchronize it with the actual guide, esp. after webpack/webpack.js.org#1439 is merged, however this should be a good starting point. It also a good baseline for issues like webpack/webpack.js.org#1443.