Skip to content

chore(hmr): add initial hot-module-replacement example #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2017
Merged

Conversation

skipjack
Copy link
Collaborator

I had this one sitting around too -- it'll probably need some work to synchronize it with the actual guide, esp. after webpack/webpack.js.org#1439 is merged, however this should be a good starting point. It also a good baseline for issues like webpack/webpack.js.org#1443.

Copy link
Owner

@TheDutchCoder TheDutchCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the missing semicolons and I'll merge this in :)

module.hot.accept('./library', function() {
console.log('Accepting the updated library module!');
Library.log();
})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;

export default {
log() {
// Change this after the server is started to test
console.log('First log...')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;

// Change this after the server is started to test
console.log('First log...')
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;

@TheDutchCoder TheDutchCoder merged commit 0afd07b into master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants