Skip to content

Binary mode: Add support for importing reports #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pasrom
Copy link
Contributor

@pasrom pasrom commented Jan 17, 2025

Enable multiple devices to exchange structured data by adding the ability to interpret binary reports received from other systems.

For an example of its usage, see: Example: Importing Reports.

This implementation may address LibreSolar/bms-c1#63.

Copy link
Contributor

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition.

Only got two minor comments.

@pasrom pasrom force-pushed the feat-bin-import-reports branch from c22ea45 to 58fba53 Compare February 2, 2025 17:45
@pasrom pasrom force-pushed the feat-bin-import-reports branch from 58fba53 to ef032dc Compare February 2, 2025 17:48
Copy link
Contributor

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@martinjaeger martinjaeger merged commit 6033e55 into ThingSet:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants