Skip to content

Commit bd81bbc

Browse files
Make AccessCredential provider_default and credential types nullable. (#259)
Unless we mark this as nullable, our generated code on the server side cannot easily discern between a user wanting to set a credential to not be the default (i.e. `"provider_default": false`) vs. not changing the default status at all (no `provider_default` field). We need similar support for our credential types as well.
1 parent 4dfe4fa commit bd81bbc

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

openapi-v2.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ definitions:
550550
provider_default:
551551
description: "True if this is the namespace's default credential to be used when connecting to the given cloud provider. There can be at most one default for each unique provider."
552552
type: boolean
553-
x-omitempty: true
553+
x-nullable: true
554554
created_at:
555555
description: "Time when the credential was created (rfc3339)"
556556
type: string
@@ -570,7 +570,7 @@ definitions:
570570
$ref: "#/definitions/AWSCredential"
571571
azure:
572572
$ref: "#/definitions/AzureCredential"
573-
573+
574574
AccessCredentialsData:
575575
description: Object including credentials and pagination metadata
576576
type: object
@@ -587,6 +587,7 @@ definitions:
587587
AWSCredential:
588588
description: "Credential information to access Amazon Web Services"
589589
type: object
590+
x-nullable: true
590591
x-omitempty: true
591592
properties:
592593
access_key_id:
@@ -601,7 +602,8 @@ definitions:
601602
AzureCredential:
602603
description: "Credential information to access Microsoft Azure. Each supported property is the snake_case version of its name in an Azure Storage connection string."
603604
type: object
604-
x-omitempty: True
605+
x-nullable: true
606+
x-omitempty: true
605607
properties:
606608
account_name:
607609
description: "The name of the Azure account to access"

0 commit comments

Comments
 (0)