Make AccessCredential provider_default and credential types nullable. #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we mark this as nullable, our generated code on the server side cannot easily discern between a user wanting to set a credential to not be the default (i.e. `"provider_default": false`) vs. not changing the default status at all (no `provider_default` field). We need similar support for our credential types as well.
alekshs
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we mark this as nullable, our generated code on the server side
cannot easily discern between a user wanting to set a credential to
not be the default (i.e.
"provider_default": false) vs. not changingthe default status at all (no
provider_defaultfield).We need similar support for our credential types as well.