Add more support for HTML. #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support is currently marked "experimental" as some features do not work correctly or are untested.
chrisfenner
reviewed
Apr 25, 2025
chrisfenner
reviewed
Apr 25, 2025
| @@ -38,7 +56,7 @@ function mermaidFigure(code, caption, attrs) | |||
| end | |||
| end | |||
|
|
|||
| local img = pandoc.Image(caption, filename) | |||
| local img = pandoc.Image(caption, filename, "", output_class["image_attrs"]) | |||
There was a problem hiding this comment.
Suggested change
| local img = pandoc.Image(caption, filename, "", output_class["image_attrs"]) | |
| local img = pandoc.Image(caption, filename, "", output_classes["image_attrs"]) |
There was a problem hiding this comment.
This is correct as-is; output_classes is keyed by output format.
chrisfenner
requested changes
Apr 25, 2025
Co-authored-by: Chris Fenner <[email protected]>
chrisfenner
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support is currently marked "experimental" as some features do not work correctly or are untested.