Updated contextUser to handle context.api_key_id #9977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-issue This just cleans up the default options parameter and doesn't mutate the options object passed in.
refs #9865 This updates the contextUser method to use the id of context.api_key_user. This means we can set the api_key_user context and all updated_by/created_by will use the correct user for the api key.
allouis
commented
Oct 10, 2018
| options = options || {}; | ||
| options.context = options.context || {}; | ||
| contextUser: function contextUser(options = {}) { | ||
| const context = options.context || {}; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
allouis
changed the title
kirrg001
reviewed
Oct 10, 2018
| const context = options.context || {}; | ||
|
|
||
| if (context.api_key_id && context.api_key_user && context.api_key_user.get('id')) { | ||
| return context.api_key_user.get('id'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Just in case @rishabhgrg is to review this PR, looking at #9976 helps to understand the context of the change ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Split out from #9869 ℹ️
👐 refs #9865 👐
This updates the contextUser method to use the id of
context.api_key_user. This means we can set the api_key_user context and
all updated_by/created_by will use the correct user for the api key.