[TT-12308] Query parameters not respected by OAS import endpoint

[MaciekMis]

User description

TT-12308

Summary	Query parameters not respected by OAS import endpoint
Type	Bug
Status	In Dev
Points	N/A
Labels	codilime_refined

---

Description

When using the Dashboard API’s OAS import endpoint to create an API from an OpenAPI document, boolean query parameters (allowList, mockResponse, validateRequest, authentication) with the value false are ignored unless the listenPath parameter is also provided. This due func IsZero not recognizing bool pointer as a non zero value.

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

• I ensured that the documentation is up to date
• I explained why this PR updates go.mod in detail with reasoning why it's required
• I would like a code coverage CI quality gate exception and have explained why

---

PR Type

Bug fix, Tests

---

Description

• Fix IsZero to treat bool pointers as non-zero values

• Add tests for bool pointer handling in ShouldOmit

• Ensure OAS import endpoint respects boolean query parameters

---

Changes walkthrough 📝

	Relevant files
Bug fix	reflect.go Fix IsZero to properly handle bool pointers                            internal/reflect/reflect.go Updated IsZero to treat non-nil bool pointers as non-zero Added explicit check for bool pointer type in pointer handling +8/-1
Tests	oasutil_test.go Add tests for bool pointer omission logic                                apidef/oas/oasutil_test.go Added BoolPtr field to test struct Added test cases for false/true bool pointers in ShouldOmit Added helper function for bool pointer creation +9/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[buger]

I'm a bot and I 👍 this PR title. 🤖

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Pointer Handling Logic The new logic for handling pointers to bool in the IsZero function changes the behavior for all pointer-to-bool values, treating any non-nil pointer as non-zero regardless of its value. This could have unintended side effects for other pointer types or usages. The reviewer should validate that this change does not introduce regressions elsewhere. if v.IsNil() { return true } if v.Elem().Kind() == reflect.Bool { return false } return IsZero(v.Elem())

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix zero check for bool pointers The current logic will always return false for any non-nil pointer to a bool, even if the value is false. This means pointers to false bools will not be considered zero, which is incorrect. Instead, explicitly check the value of the pointed-to bool and return true if it is false. internal/reflect/reflect.go [39-47] case reflect.Ptr: if v.IsNil() { return true } if v.Elem().Kind() == reflect.Bool { - return false + return !v.Elem().Bool() } return IsZero(v.Elem()) Suggestion importance[1-10]: 9 __ Why: This suggestion correctly identifies and fixes a logic bug: the original code always returns false for non-nil *bool, even if the value is false, which is not the intended "zero" behavior. The improved code properly checks the pointed-to bool value, ensuring accurate zero-value detection for *bool. This is a critical correctness fix.	High

[github-actions]

API Changes

no api changes detected

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[MaciekMis]

/release to release-5.8

[tykbot]

Working on it! Note that it can take a few minutes.

[tykbot]

@MaciekMis Created merge PRs