Add dynamic fee modal

[bajajanirudh]

No description provided.

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Dynamic require	npm/[email protected]	Location: Package overview	package-lock.json package.json	⚠︎
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	package-lock.json package.json	⚠︎

View full report↗︎

Next steps

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]

[socket-security]

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	environment, filesystem	0	75.8 kB	motdotla
npm/[email protected]	environment, filesystem Transitive: eval, shell	+56	4.72 MB	juergba

View full report↗︎

[louisbrown0212]

It can save gas

Suggested change

	uint256 amount = uint256(abs(amount0Delta > 0 ? amount0Delta : amount1Delta));
	uint256 amount = uint256(amount0Delta > 0 ? amount0Delta : abs(amount1Delta));

[louisbrown0212]

It's view function, but also it's called in swapWithDynamicFee and addLiquidityWithDynamicFee functions.
So it should be gas optimized.

Suggested change

	uint256 currentTime = block.timestamp;
	for (uint256 i = 0; i < swapHistory.length; i++) {
	uint256 currentTime = block.timestamp;
	uint256 numHistory = swapHistory.length;
	for (uint256 i = 0; i < numHistory; ++i) {

[louisbrown0212]

If fee is below MIN_FEE, it's not necessary to check whether it's above MAX_FEE

Suggested change

	if (fee > MAX_FEE) fee = MAX_FEE;
	else if (fee > MAX_FEE) fee = MAX_FEE;

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Rayluv29]

Interesting