Skip to content

feat(CalendarRange): make accessible from keyboard and screen reader #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 17, 2025
Merged

feat(CalendarRange): make accessible from keyboard and screen reader #8515

merged 10 commits into from
Jun 17, 2025

Conversation

andrey-medvedev-vk
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk commented Apr 25, 2025 •
edited by EldarMuhamethanov
Loading

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Нужно по примеру реализации в #8487 доработать доступность компонента CalendarRange

Изменения

Release notes

Улучшения

  • CalendarRange: Улучшена навигация с помощью клавиатуры и скринридера

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 413.43 KB (+0.32% 🔺)
JS (gzip) 123.12 KB (+0.35% 🔺)
JS (brotli) 100.98 KB (+0.28% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.73 KB (0%)
CSS (gzip) 43.37 KB (0%)
CSS (brotli) 34.57 KB (0%)

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (2e86cf8) to head (fa7ead3).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8515      +/-   ##
==========================================
+ Coverage   95.92%   95.96%   +0.03%     
==========================================
  Files         419      420       +1     
  Lines       12035    12106      +71     
  Branches     3985     4012      +27     
==========================================
+ Hits        11545    11617      +72     
+ Misses        490      489       -1
Flag Coverage Δ
unittests 95.96% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 3, 2025
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@inomdzhon inomdzhon reopened this May 15, 2025
@inomdzhon inomdzhon added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels May 15, 2025
@inomdzhon inomdzhon added this to VKUI May 15, 2025
@EldarMuhamethanov
Merge branch 'master' into mendrew/feat/CalendarRange/make-accessible
afdc029 
# Conflicts:
#	packages/vkui/src/components/CalendarRange/CalendarRange.tsx
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2025 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2025 •
edited
Loading

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8515/fa7ead38280ef1ddb09fc02d66351c4975d9a115/pkg/@vkontakte/vkui/_pkg.tgz

Commit fa7ead3

@EldarMuhamethanov EldarMuhamethanov self-assigned this May 21, 2025
@EldarMuhamethanov EldarMuhamethanov added a11y Доступность (цифровая) cmp:calendar-range labels May 21, 2025
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review May 21, 2025 13:01
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner May 21, 2025 13:01
@EldarMuhamethanov EldarMuhamethanov changed the title CalendarRange: make accessible feat(CalendarRange): make accessible from keyboard and screen reader May 21, 2025
@EldarMuhamethanov EldarMuhamethanov moved this to 👀 In Review in VKUI May 21, 2025
This was referenced May 26, 2025
Merged
Closed
inomdzhon
inomdzhon reviewed May 30, 2025
View reviewed changes
EldarMuhamethanov and others added 2 commits May 30, 2025 17:47
inomdzhon
inomdzhon approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

@EldarMuhamethanov EldarMuhamethanov merged commit 028fe98 into master Jun 17, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the mendrew/feat/CalendarRange/make-accessible branch June 17, 2025 17:25
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EldarMuhamethanov EldarMuhamethanov EldarMuhamethanov left review comments

@inomdzhon inomdzhon inomdzhon approved these changes

@BlackySoul BlackySoul BlackySoul approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
a11y Доступность (цифровая) cmp:calendar-range no-stale Добавляет PR в исключения для автоматического закрытия
Projects
VKUI
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrey-medvedev-vk @vkcom-publisher @inomdzhon @BlackySoul @EldarMuhamethanov