Skip to content

tech: migrate storybook from 8 to 9 #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Jun 3, 2025


Описание

см. https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-8x-to-900

Изменения

На что обратить внимание:

  • Удалил storybook из правила 'no-restricted-imports' в packages/vkui/eslintrc.cjs, т.к. конфликтует с тем, что многие импорты теперь идут из пакета самого storybook.

  • Для аддона storybook-theme тип теперь TOOLEXTRA вместо experimental_SIDEBAR_TOP.

    Note
    Теперь кнопка находится справа сверху.

  • Заменил @storybook/react-webpack5 на @storybook/react-vite – SWC прикрутить опции нет, но тем не менее собирается за 15 секунд на M1, что прилично.

  • Перенёс все зависимости storybook в корневой package.json. В tools/storybook-addon-cartesian оставил только необходимое. Заодно сделал дедпуликацию пакетов.

  • @storybook/addon-console пока пришлось отключить, т.к. не поддерживает 9 версию (Storybook 9 compatibility storybookjs/storybook-addon-console#86)

Release notes

Документация

  • Storybook обновлён с 8 до 9 версии

@inomdzhon inomdzhon self-assigned this Jun 3, 2025
@inomdzhon inomdzhon requested a review from a team as a code owner June 3, 2025 18:21
@inomdzhon inomdzhon added this to VKUI Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

size-limit report 📦

Path Size
JS 409.06 KB (0%)
JS (gzip) 121.9 KB (0%)
JS (brotli) 100.13 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.12 KB (0%)
CSS (gzip) 43.25 KB (0%)
CSS (brotli) 34.51 KB (0%)

Copy link
Contributor

github-actions bot commented Jun 3, 2025

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 3, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8635/0d67ec6359d51f8b752fa29468e293b27dcb38c3/pkg/@vkontakte/vkui/_pkg.tgz

Commit 0d67ec6

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (8a92a7f) to head (0d67ec6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8635   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         416      416           
  Lines       11935    11935           
  Branches     3949     3949           
=======================================
  Hits        11445    11445           
  Misses        490      490           
Flag Coverage Δ
unittests 95.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Jun 4, 2025
@inomdzhon inomdzhon added this to the v7.4.0 milestone Jun 4, 2025
@inomdzhon inomdzhon merged commit ebade8c into master Jun 4, 2025
29 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/tech/migrate-to-storybook-9 branch June 4, 2025 09:54
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jun 4, 2025
@vkcom-publisher
Copy link
Contributor

v7.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants