Skip to content

Implement Pull Request Handling #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

namphuongtran
Copy link
Collaborator

Implement tool to create Pull Requests
Implement tool to update Pull Request details
Implement tool to list Pull Requests (with filtering)
Implement tool to get Pull Request details
Implement tool to add comments to Pull Requests
Implement tool to approve/reject Pull Requests
Implement tool to complete (merge) Pull Requests
Support filtering PRs by status, creator, reviewer, etc.
Add comprehensive error handling
Write unit tests for all functionality

@namphuongtran namphuongtran requested a review from Vortiago March 29, 2025 07:00

# Create the pull request
result = self.git_client.create_pull_request(
git_pull_request=pull_request,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm this is correct? I think it should be git_pull_request_to_create here instead of git_pull_request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else it is failing, I have tested your branch


# Send the update
result = self.git_client.update_pull_request(
git_pull_request=existing_pr,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also it should be git_pull_request_to_update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be other arguments which will not work, for example create_pull_request_refs,,,, to link work items was also giving an error

@RobinDBookU
Copy link

Hi @Vortiago — thanks for all the work on this repository! I’m not looking to contribute code, but I’d love to use this feature in my own project. Do you have any sense of when it might be merged or released? No rush—just curious about the timeline. Thanks! 🙏

@Vortiago
Copy link
Owner

I've started to take a look at the PR. Looks like much of it works but at the moment one of the tool calls have a small problem.

image

@Vortiago
Copy link
Owner

Same with this tool call.
image

@Vortiago
Copy link
Owner

I fixed some spelling errors on SDK calls to fix the tool calls. The implementation for getting a list of changed files and changes in those files are not working for me. But a lot of the other tool calls are.

@Vortiago
Copy link
Owner

@namphuongtran , after testing yesterday I think the last feature not working correctly that I'd like to have in place before merging this is the tool call to get list of changed files and their changes. The other workflows I could think about and tested worked fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants