This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Unify externref and anyref #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobkummerow
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
LGTM.
I think this PR is an improvement, so I think it's fine to go ahead with it. Orthogonal questions that came up before and that we can settle separately include:
- do we want an
opaquereftype (that doesn't supportref.is_dataetc), or isanyrefperfectly sufficient for the use cases we can think of? - do we want a
wasmreftype that's the supertype of all Wasm-defined types? - do we really want to re-introduce the
funcref <: anyrefrelation right now, or do the reasons we had earlier for dropping/postponing that still hold?
If anyone has thoughts on these questions, those should probably be discussed in (new or existing) issues, not on this PR.
This was referenced Feb 10, 2022
Closed
This was referenced May 4, 2022
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies externref and anyref by renaming the former to the latter and removing the new opcode. For backwards compatibility, the keywords
externandexternrefare still recognised in the text format as aliases.Resolves #256.