Skip to content

Customize Force Layout #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Customize Force Layout #510

wants to merge 11 commits into from

Conversation

camillobruni
Copy link
Contributor

Currently we have two different modes in which we force layout

  • getBoundingClientRect used by default in the benchmark runner and tests
  • elementFromPoint used in the remote workloads

This PR adds a new layoutMode param to switch between the two modes.

@netlify Netlify
Copy link

netlify bot commented Apr 30, 2025 •
edited
Loading

✅ Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit f0d12c7
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/6835e06fe13f250008474760
😎 Deploy Preview https://deploy-preview-510--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni added non-trivial change A change that affects benchmark results trivial change A change that doesn't affect benchmark results and removed non-trivial change A change that affects benchmark results labels Apr 30, 2025
@camillobruni camillobruni requested review from rniwa and julienw April 30, 2025 08:12
julienw
julienw requested changes May 5, 2025
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this looks good to me

Just a couple of suggestions, tell me what you think

@camillobruni camillobruni requested a review from julienw May 7, 2025 22:29
julienw
julienw reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new code doesn't have the same perf characteristics as the old one, speedometer seems to run faster. Do you see that as well?

@camillobruni
Copy link
Contributor Author

Just double-checked and I can't really see a perf diff anymore.

rniwa
rniwa reviewed May 21, 2025
View reviewed changes
rniwa
rniwa reviewed May 21, 2025
View reviewed changes
camillobruni
camillobruni commented May 27, 2025
View reviewed changes
Copy link
Contributor Author

@camillobruni camillobruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw requested changes

@rniwa rniwa rniwa approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
trivial change A change that doesn't affect benchmark results v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camillobruni @rniwa @julienw