[WPE][GTK] visible rect in case animations is not correctly calculated #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=280612 Reviewed by Miguel Gomez. For animations starting partially outside the viewport were not fully rendered when the first frame entered the visible area. This caused incomplete or cut-off frames during the initial stages of the animation. The issue was more noticeable on low-end devices(RPi) or during slow-motion or frame-by-frame analysis of the recordings on x86. With this change the visible rect is extended with the elements which are currently not fully visible but they will be in a future bacause of animations. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::transformedVisibleRectIncludingFuture): (WebCore::CoordinatedGraphicsLayer::updateContentBuffers): (WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
pgorszkowski-igalia
requested review from
magomez and
zdobersek
as code owners
magomez
approved these changes
Oct 8, 2024
gowthami-cl-infosys
added a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Oct 14, 2024
…lly Loading in Carousel slider. changes taken from the upstream: WebPlatformForEmbedded#1411
gowthami-cl-infosys
added a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Oct 21, 2024
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
gowthami-cl-infosys
added a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Oct 24, 2024
…Fully Loading in Carousel slider changes taken from the upstream : WebPlatformForEmbedded#1411
varadharajan-v
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Oct 25, 2024
…Fully Loading in Carousel slider changes taken from the upstream : WebPlatformForEmbedded#1411
suresh-khurdiya-infosys
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Nov 28, 2024
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
suresh-khurdiya-infosys
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Dec 10, 2024
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
volodymyr-ogorodnik-red
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Apr 25, 2025
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
volodymyr-ogorodnik-red
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Apr 25, 2025
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
volodymyr-ogorodnik-red
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Apr 28, 2025
…Fully Loading in Carousel slider changes taken from the upstream: WebPlatformForEmbedded#1411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.webkit.org/show_bug.cgi?id=280612
Reviewed by Miguel Gomez.
For animations starting partially outside the viewport were not fully rendered when the first frame entered the visible area. This caused incomplete or cut-off frames during the initial stages of the animation. The issue was more noticeable on low-end devices(RPi) or during slow-motion or frame-by-frame analysis of the recordings on x86.
With this change the visible rect is extended with the elements which are currently not fully visible but they will be in a future bacause of animations.