Skip to content

fix controller params #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mikeferguson
Copy link
Contributor

@mikeferguson mikeferguson requested a review from a team as a code owner April 28, 2020 15:31
@mikeferguson
Copy link
Contributor Author

Without this, you end up with defaults (5.0 and 5.0)

Copy link
Contributor

@cjds cjds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRTM @erelson assigning you for the merge?

@mikeferguson
Copy link
Contributor Author

mikeferguson commented Apr 28, 2020

Hold on a second - didn't mean to change vth_samples - Ok fixed.

@mikeferguson
Copy link
Contributor Author

Actually, this doesn't work anyways - the dynamic reconfigure limits are set to 5.0 - that's why I keep getting values of 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants