Correct Missing Type Annotations #17 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect this isn't perfect....feedback pls.... |
FoamyGuy
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks for working on this. The types that you have in are looking pretty good to me. I found a few functions without still that we can round out.
I think we can type the bind() function here: https://github.com/tcfranks/Adafruit_CircuitPython_BLE_File_Transfer/blob/dca365e252cb829e44fe975698a9ed6321a40e72/adafruit_ble_file_transfer.py#L68 with Service and PacketBuffer` types for argument and returns.
|
Ready for 2nd review, I think. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.