Skip to content

Is _backwards_compatible_sock flag still needed #204

Open
@justmobilize

Description

@justmobilize

Is _backwards_compatible_sock flag still needed? In MQTT._sock_exact_recv there is this code:

        if not self._backwards_compatible_sock:
            # CPython/Socketpool Impl.
            ...

        else:  # ESP32SPI Impl.
            # This will timeout with socket timeout (not keepalive timeout)
            ...

This flag is set by:

self._backwards_compatible_sock = not hasattr(sock, "recv_into")

here

Yet at this point both the ESP32SPI library and WIZNET5k library have recv_into.

The FONA library is the only one I see that doesn't

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions