enable DRVSTR for output pin #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add neopixel and button pin define for circuitplay
hathach
commented
Dec 13, 2021
|
|
||
| case OUTPUT: | ||
| // enable input, to support reading back values, with pullups disabled | ||
| PORT->Group[port].PINCFG[pin].reg=(uint8_t)(PORT_PINCFG_INEN) ; | ||
| PORT->Group[port].PINCFG[pin].reg = (uint8_t) (PORT_PINCFG_INEN | PORT_PINCFG_DRVSTR); |
There was a problem hiding this comment.
PORT_PINCFG_DRVSTR for output pin, the rest is formatting.
There was a problem hiding this comment.
Looks good to me (which is to say it's exactly the patch I imagined, if I were brave enough to make this change across all SAMD platforms.)
ladyada
approved these changes
Dec 14, 2021
|
@hathach thanks :) can do a release now - i also added the feather m4 adalogger so a release is due |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseded and close #312, fix #311