Fixes REPL not booting on heltec_esp32s3_wifi_lora_v3. #10408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly this leads to some code size savings on itsybitsym4, even though LTO optimization should have let the compiler deduce (almost) all of this. When a compiler knows a call can never return, it is possibly able to avoid emitting code, such as saving caller-saved registers to the stack, or doing _ANYTHING_ affter the function returns, explaining why code size savings is possible with this attribute. With the exception of raise_deinited_error, these were found by checking the functions found by `-Wmissing-noreturn` and making a case by case decision. However, this dignostic can't be enabled unconditionally as it has false positives, functions we do NOT want to mark as noreturn. Testing performed: built itsybitsy m4, flash size savings 128 bytes. didn't test on hardware as none came on this trip with me.
This was only used in espressif but became a no-op in 5e26862 so it should just be removed.
bitmaptools.arrayblit fix: make x2,y2 optional and update docstring
Remove unneeded "post_boot_py"
Mark functions as NORETURN
…queue-ops extmod/modasyncio.c: remove push_head, push_sorted, pop_head
… and mov_status_n.
…ck speed settings.
* Use 0 bytes for QSTR hash. Fixes adafruit#10151 * Update libgcc used on SAMD21 to 14.2. Reduces test build by over 100 bytes. * Turn off 'd' typecode support on non-full builds.
…_atomic_test_and_set.
Audio Effect Multi-Tap Delay
Currently translated at 100.0% (1013 of 1013 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/en_GB/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/
…re-ports Enable -Werror=old-style-definition against more ports
…covery nordic: Fix BLE HID to work after deep sleep
improve keypad doc re RP2350 E-9 erratum
9.2.x merge into main
switch to gcc 14.2Rel1
Update ping action version
Currently translated at 100.0% (1015 of 1015 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/zh_Latn/
The waveshare_esp32_s3_zero/mpconfigboard.h file does not have SPI nor IC2 defined. I suspect this board was built off another board and while the SPI and IC2 definitions were correctly removed from the mpconfigboard.h file, they were accidentally left in the pins.c file. So if you call a board.I2C or board.SPI you get an error even though they show up in 'dir (board)'. The board does not have any silkscreen for these busses nor are the specifically called out in the schematic. https://www.waveshare.com/wiki/ESP32-S3-Zero
…main Translations update from Hosted Weblate
Update pins.c
Currently translated at 100.0% (1015 of 1015 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/en_GB/
…main Translations update from Hosted Weblate
…hain fixed download URL (has 14.2 twice in the url)
…LED and I2C pull-ups.
dhalbert
requested changes
Jun 9, 2025
There was a problem hiding this comment.
Hi - this is merging from main to 9.2.x, which is causing an excessive number of commits.
Side comment, not related to the above: we suggest creating your own branch instead of using your main for changes, which causes your main to get out of sync with upstream main. See https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch#create-your-new-branch-2992239
|
Thanks for the feedback. I tried following that guide the first time, but I didn't do it correctly. Now, I am unsure what to do next. I'll just close this request. |
|
Here are some ideas for how to fix:
|
You will probably be able to do that with your existing commit(s), without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10407.
Changed the GPIO in board.c, which controls the rail for the OLED screen and I2C pull-ups. Also added RESET signal to busdisplay constructor.
Tested with two Heltec WiFi LoRa V3 boards. On power-up the OLED shows the CircuitPython REPL. Opening serial port shows boot getting past
Serial console setupand into the REPL. I was able to upload libraries and run code viacode.circuitpython.org.