Add root cert DST Root CA X3 for Let's Encrypt #8386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlitzCityDIY
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
thanks @dhalbert ! tested the generated UF2 from here on the matrixportal s3 and it is working with the API
jepler
pushed a commit
to jepler/circuitpython
that referenced
this pull request
Nov 3, 2024
Allows mpremote file transfer to work correctly when mpremote is used over the ST-link USB/UART REPL port. Fixes issue adafruit#8386. Signed-off-by: Andrew Leech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an (expired) root cert,
DST Root CA X3, to the roots cert list to handle the special way Let's Encrypt does its root cert. See details here: adafruit/certificates#1.This cert was present in the older NINA-FW list. It was removed when the roots cert bundle was completely reworked in #8374. But mbedTLS does not seem to work properly with the Let's Encrypt scheme without this cert.
Discovered by @BlitzCityDIY while using
site.api.espn.com.