Skip to content

Fixes #9 - unify errors #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Fixes #9 - unify errors #11

merged 4 commits into from
Jun 11, 2019

Conversation

shazron
Copy link
Member

@shazron shazron commented Jun 11, 2019

Description

Unifies errors by using an Error object for all promise rejections.

Related Issue

See #9

Motivation and Context

For users of this lib, it will end up in cleaner code rather than trying to handle the various types of promise rejections.

How Has This Been Tested?

Passes all npm test scenarios.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member Author

shazron commented Jun 11, 2019

Tests are pending for the new errors. Existing tests pass.

@shazron shazron changed the title WIP Fixes #9 - unify errors Fixes #9 - unify errors Jun 11, 2019
@shazron shazron requested a review from macdonst June 11, 2019 08:02
@shazron
Copy link
Member Author

shazron commented Jun 11, 2019

Tests done.

@macdonst macdonst merged commit 43293dc into adobe:master Jun 11, 2019
@shazron shazron deleted the unify-errors branch June 11, 2019 11:29
@Aaronius Aaronius mentioned this pull request Oct 11, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants