Skip to content

chore: release github action #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

castastrophe
Copy link
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@castastrophe castastrophe force-pushed the chore-release-action branch from 416039c to 45bb8b9 Compare May 7, 2025 21:16
Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 0a0833d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented May 7, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented May 7, 2025

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the chore-release-action branch from 45bb8b9 to c96fb67 Compare May 8, 2025 13:57
@castastrophe castastrophe force-pushed the chore-release-action branch from c96fb67 to a0c04f6 Compare June 12, 2025 16:06
@castastrophe castastrophe force-pushed the chore-release-action branch from a0c04f6 to 0a0833d Compare June 16, 2025 18:59
Comment on lines 85 to +87
"test:watch:focus": "yarn build && run-p build:watch \"test:start --watch --group {1}\" --",
"version:update": "genversion --verbose --semi --esm ./tools/base/src/version.js",
"version:packages": "yarn config set -H enableImmutableInstalls false && changeset version && yarn lint",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'version:packages' should be before 'version:update'.

Suggested change
"test:watch:focus": "yarn build && run-p build:watch \"test:start --watch --group {1}\" --",
"version:update": "genversion --verbose --semi --esm ./tools/base/src/version.js",
"version:packages": "yarn config set -H enableImmutableInstalls false && changeset version && yarn lint",
"test:watch:focus": "yarn build && run-p build:watch \"test:start --watch --group {1}\" --",
"version:packages": "yarn config set -H enableImmutableInstalls false && changeset version && yarn lint",
"version:update": "genversion --verbose --semi --esm ./tools/base/src/version.js",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant