Skip to content

PAGE_MAX_SIZE and PAGE_MIN_SIZE expanded as macros on MacOS #592

Closed
@marcingib

Description

@marcingib

Following error occurs on MacOS:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DBOOST_LOG_DYN_LINK -Drdlib_EXPORTS -I. -I/usr/local/aeron/include -I../../src/rdlib/include -I../../src/rdlib/. -isystem /usr/local/include -isystem /usr/local/include/tensorflow -std=c++14 -O3 -DNDEBUG -O3 -march=native -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fPIC   -fcolor-diagnostics -Qunused-arguments -include /Users/marg/prog/rd/build/release/src/rdlib/cotire/rdlib_CXX_prefix.hxx -MD -MT src/rdlib/CMakeFiles/rdlib.dir/engine/net/AeronManager.cpp.o -MF src/rdlib/CMakeFiles/rdlib.dir/engine/net/AeronManager.cpp.o.d -o src/rdlib/CMakeFiles/rdlib.dir/engine/net/AeronManager.cpp.o -c ../../src/rdlib/engine/net/AeronManager.cpp
In file included from ../../src/rdlib/engine/net/AeronManager.cpp:6:
In file included from /usr/local/aeron/include/Aeron.h:24:
In file included from /usr/local/aeron/include/concurrent/logbuffer/TermReader.h:23:
/usr/local/aeron/include/concurrent/logbuffer/LogBufferDescriptor.h:34:27: error: expected unqualified-id
static const std::int32_t PAGE_MIN_SIZE = 4 * 1024;
                          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:107:33: note: expanded from macro 'PAGE_MIN_SIZE'
#define PAGE_MIN_SIZE           PAGE_SIZE

There's workaround to add following lines before including Aeron.h:

#undef PAGE_MAX_SIZE
#undef PAGE_MIN_SIZE

Please consider renaming these variables.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions