Skip to content

Update ghpages command to use gh-pages instead of unmaintained ghpages #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

vincentfretin
Copy link
Contributor

https://github.com/cvan/ghpages is not maintained (6 vulnerabilities reported) and is just a wrapper to https://github.com/tschaub/gh-pages
Update the command to use gh-pages directly.
I tested the npm run deploy command, that works properly like before.

Before the change:

12 vulnerabilities (1 low, 3 moderate, 6 high, 2 critical)

After the change:

6 vulnerabilities (1 low, 3 moderate, 2 high)
added 11 packages, removed 54 packages, changed 5 packages, and audited 1201 packages in 7s

and then after doing npm audit fix to fix the remaining vulnerabilities:

found 0 vulnerabilities

@dmarcos
Copy link
Member

dmarcos commented Jan 14, 2025

thanks

@dmarcos dmarcos merged commit 026475a into aframevr:master Jan 14, 2025
1 check passed
@vincentfretin vincentfretin deleted the update-gh-pages branch January 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants