Skip to content

[Bug Fix] Update dist_neighbor_sampler to handle heterogeneous case where node labels is None #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

mkolodner-sc
Copy link
Contributor

This PR aims to fix dist_neighbor_sampler which fails in the heterogeneous case when self.dist_node_labels=None. There is an assert statement which enforces this field to be a dictionary, but the subsequent line implies that we should be allowing for this to also be None:

if self.dist_node_labels is not None and all(isinstance(value, Feature) for value in self.dist_node_labels.values()):

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2025

CLA assistant check
All committers have signed the CLA.

@husimplicity husimplicity merged commit cb61c27 into alibaba:main Apr 1, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants