Fix repr of Signature so it works for subclasses

[robtaylor]

At the moment the __repr__ for Signature doesn't work for derived classes of Signature (as used e.g. in Glasgow).

Simple fix here.

[whitequark]

Apologies, it seems like I've never submitted a review.

[whitequark]

This isn't a correct fix. There are two problems with it.

1. A repr is supposed to give information about the class name as well. Your fix would incorrectly indicate that the class name is Signature rather than whatever the subclass is.
2. Subclassing Signature is only really useful if you're going to add non-member attributes to it. But the default implementation only prints members. The check here serves as a nudge to implementers to make sure they really did cover all attributes.

[robtaylor]

Makes sense :)

…

On Thu, 3 Jul 2025 at 02:40, Catherine ***@***.***> wrote: ***@***.**** requested changes on this pull request. Apologies, it seems like I've never submitted a review. ------------------------------ In amaranth/lib/wiring.py <#1552 (comment)> : > @@ -1002,7 +1002,7 @@ def annotations(self, obj, /): return tuple() def __repr__(self): - if type(self) is Signature: + if isinstance(self, Signature): return f"Signature({dict(self.members.items())})" This isn't a correct fix. There are two problems with it. 1. A repr is supposed to give information about the class name as well. Your fix would incorrectly indicate that the class name is Signature rather than whatever the subclass is. 2. Subclassing Signature is only really useful if you're going to add non-member attributes to it. But the default implementation only prints members. The check here serves as a nudge to implementers to make sure they really did cover all attributes. — Reply to this email directly, view it on GitHub <#1552 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB4O4C2U37WFHUPYWVJ62D3GR3WBAVCNFSM6AAAAABVNNNPK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBRGA2DQOJWGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>