Add support for syntax highlighting in PyREPL #89
Conversation
ambv
force-pushed
the
pyrepl-syntax-highlighting
branch
from
627056f to
aebc35f
Compare
ambv
force-pushed
the
pyrepl-sh-refactor-calc-screen
branch
from
4ab5a7b to
31c48b2
Compare
| for c in buffer: | ||
| while colors and colors[0].span.end < start_index: | ||
| # move past irrelevant spans | ||
| colors.pop(0) |
There was a problem hiding this comment.
I know this list is not big enough that it matters but it would recommend modifying this to figure out the cutting index and then slicing once
| pre_color = "" | ||
| post_color = "" | ||
|
|
||
| if colors and colors[0].span.start < i and colors[0].span.end > i: |
There was a problem hiding this comment.
This approach assumes the next call to disp_str() will properly handle the color continuation. If any buffer modification happens between calls, or if the next call uses different parameters, you'll get incorrect highlighting no?
Maybe this is a no problem but I would recommend to either add some defensive check or an assert
SYNC"]
# Then in the next call, verify consistency
if pending_color_span and colors and colors[0].span == pending_color_span.span:
# Spans match, continue highlighting
pre_color = TAG_TO_ANSI[colors[0].tag]
else:
…
| post_color = TAG_TO_ANSI["SYNC"] | ||
| colors.pop(0) | ||
|
|
||
| chars[-1] = pre_color + chars[-1] + post_color |
There was a problem hiding this comment.
Not sure if this matters but this being in a tight loop may be a performance problem
| @@ -355,3 +362,60 @@ def test_setpos_from_xy_for_non_printing_char(self): | |||
| reader, _ = handle_all_events(events) | |||
| reader.setpos_from_xy(8, 0) | |||
| self.assertEqual(reader.pos, 7) | |||
|
|
|||
| def test_syntax_highlighting_basic(self): | |||
There was a problem hiding this comment.
I would recommend adding some extra test for edge cases and failure modes such as incomplete code blocks, syntax errors and other known failure conditions so we know how this will behave
ambv
force-pushed
the
pyrepl-sh-refactor-calc-screen
branch
from
31c48b2 to
f9f4722
Compare
ambv
force-pushed
the
pyrepl-syntax-highlighting
branch
from
aebc35f to
35f01ca
Compare
|
Moved on to python#131562. |
No description provided.