Skip to content

Attendance Page #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Attendance Page #36

wants to merge 7 commits into from

Conversation

wavexnani
Copy link

@wavexnani wavexnani commented Jun 6, 2025


Attendance Tracking System Enhancements

This release brings significant improvements to our attendance tracking system, focusing on more efficient data retrieval, enhanced visual reporting, and greater flexibility for historical data access.

Optimized Attendance Data Retrieval

We've refined the data fetching process within attendance-service.ts. Previously, two separate database queries were executed: one for basic member details (member ID, name, year) and another for their specific attendance records (member ID, time-in, time-out, and present status). After retrieving these, a mapping function combined the data for each member.

Now, we've consolidated these into a single, comprehensive query. This new query efficiently retrieves all necessary member and attendance information at once. As a result, the subsequent mapping logic in the AttendanceService function is no longer needed and has been removed, leading to cleaner code and improved performance.

New Attendance Metrics Visualizations

To provide a clearer and more immediate overview of attendance, we've added new visual components to the right side of the page:

  • A Pie Chart
  • A Bar Chart

These charts display the number of members present, absent, and late, offering quick, at-a-glance insights into daily attendance patterns.

Enhanced Calendar Component Functionality

The calendar component has been upgraded to make accessing historical attendance data much easier:

  • A new dropdown menu has been integrated, allowing users to select any specific month and year.
  • This new feature enables you to effortlessly retrieve and view attendance data for any particular day within your chosen month and year.

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for zingy-speculoos-372a93 ready!

Name Link
🔨 Latest commit 8844938
🔍 Latest deploy log https://app.netlify.com/projects/zingy-speculoos-372a93/deploys/685130d745ccc200087a0caa
😎 Deploy Preview https://deploy-preview-36--zingy-speculoos-372a93.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hrideshmg
Copy link
Member

hrideshmg commented Jun 12, 2025

Thanks for the PR! I'll leave the actual review of the code to @sabarixr, but I wanted to share some suggestions regarding the structure of the PR itself.

Firstly, I noticed that you have a lot of commits in the PR, while this is not inherently a bad thing you might want to consider squashing certain commits to make sure that they are modular, i.e. it only does one thing. Here in particular, you added a radar graph in one commit and removed it in a later commit, so this would be a perfect opportunity to squash the two and just name it something like feat: add pie chart for attendance

Coming to the commit messages themselves, they are a bit clunky. The commit messages should concisely summarize the changes made, should use proper grammar and be in the imperative mood. I'm seeing a lot of grammatical mistakes in yours, it's not a bad idea to run them once through GPT to make sure they are proper.
You can also look at conventional commits for a style that is pretty popular and this blog post for more general info.

Thirdly, whenever it comes to UI changes, it's always a good idea to include a few screenshots displaying your work.

…ble dynamic year range

Removed the default white styling in Safari’s calendar dropdown using appearance-none in Tailwind
CSS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants