Skip to content

Added support for methods with same name but different signatures #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jose
Copy link

@jose jose commented Jan 24, 2021

No description provided.

@andrefreitas
Copy link
Owner

Thanks for your contribution @jose, it's appreciated. My feedback is the following:

  1. Can you please add this scenario in the Java Parser tests? https://github.com/andrefreitas/schwa/blob/master/schwa/test/java_parser_test.py.
  2. If possible, can you provide how you tested this change? Perhaps a public repo?

@jose
Copy link
Author

jose commented Feb 17, 2021

Hi @andrefreitas,

Can you please add this scenario in the Java Parser tests?

A test has been added to the java_parser_test.py file and all the other tests have been updated.

If possible, can you provide how you tested this change? Perhaps a public repo?

Sure. You can find a demo/example in here.

PS: the build is currently failing due to the gitpython-developers/GitPython#983 issue and not because there are faults in this pull request. Pull request #6 addresses that GitPython issue.

--
Best,
Jose

@andrefreitas
Copy link
Owner

Update: I'm lacking the time and energy to follow up on this. To not create false expectation, i'm closing this issue.

It's better to run your own fork of Schwa and adapt it to your use cases.

Thanks for your time @jose and all the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants