Skip to content

Inline gradle-wrapper-validation job. #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jan 29, 2024
Merged

Inline gradle-wrapper-validation job. #2129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18221af
Inline gradle-wrapper-validation job.
brettchabot Jan 29, 2024
1dd2af5
Update versions of github actions to avoid Node.js deprecation warning.
brettchabot Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,19 @@ env:
cache-version: v1

jobs:
gradle-wrapper-validation:
name: gradle-wrapper-validation
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: gradle/wrapper-validation-action@v1
build:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Check out repository code
uses: actions/checkout@v3
uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test: job's checkout is still v3 I think, see warnings:
https://github.com/android/android-test/actions/runs/7702474927?pr=2129

- name: Install Java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: '17'
- name: 'Cache Bazel files'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/bazel
key: ${{ runner.os }}-${{ env.cache-version }}-bazel-build-${{ github.sha }}
Expand Down Expand Up @@ -66,14 +60,14 @@ jobs:
timeout-minutes: 20
steps:
- name: Check out repository code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: '17'
- name: 'Cache Bazel files'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/bazel
key: ${{ runner.os }}-${{ env.cache-version }}-bazel-test-${{ github.sha }}
Expand All @@ -94,23 +88,25 @@ jobs:
shell: bash
gradle-emulator-test:
runs-on: ubuntu-latest
needs: [build, gradle-wrapper-validation]
needs: [build]
timeout-minutes: 20
steps:
- name: Check out repository code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: '17'
- name: Gradle wrapper validation
uses: gradle/wrapper-validation-action@v2
- name: Enable KVM group perms
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
- name: 'Cache Gradle files'
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3
- name: 'Download local snapshot for tests'
uses: actions/download-artifact@v4
with:
Expand All @@ -122,7 +118,7 @@ jobs:
unzip ~/download/axt_m2repository.zip -d ~/.m2/
shell: bash
- name: 'Setup Android SDK'
uses: android-actions/setup-android@v2
uses: android-actions/setup-android@v3
- name: 'Run gradle tests'
run: |
cd ${{ github.workspace }}/gradle-tests
Expand Down