Skip to content

[Jetcaster] Improve scroll performance of podcast pager #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2023
Merged

[Jetcaster] Improve scroll performance of podcast pager #1106

merged 6 commits into from
May 7, 2023

Conversation

bentrengrove
Copy link
Member

  • Migrated to Foundation Pager
  • Ensured pager item composable could be skipped
  • Migrated gradient modifier to Modifier.Node

@bentrengrove bentrengrove requested a review from arriolac April 4, 2023 03:33
@bentrengrove bentrengrove requested a review from a team as a code owner April 4, 2023 03:33
@bentrengrove bentrengrove mentioned this pull request May 7, 2023
Closed
@bentrengrove bentrengrove force-pushed the ben/podcast_pager_performance branch from d37ee89 to 22303be Compare May 7, 2023 22:29
@bentrengrove bentrengrove merged commit cd36d0d into main May 7, 2023
@bentrengrove bentrengrove deleted the ben/podcast_pager_performance branch May 7, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florina-muntenescu florina-muntenescu florina-muntenescu approved these changes

@arriolac arriolac Awaiting requested review from arriolac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentrengrove @florina-muntenescu