Skip to content

Support Ivy compiler for redux-router #108

Open
@ChugunovD

Description

@ChugunovD

This is a...

  • feature request
  • bug report
  • usage question

What toolchain are you using for transpilation/bundling?

  • @angular/cli
  • Custom @ngTools/webpack
  • Raw ngc
  • SystemJS
  • Rollup
  • Other

Environment

NodeJS Version: v10.15.3
Typescript Version: ~3.6.4
Angular Version: ~9.0.0-rc.6
@angular-redux/store version: ^9.0.0
@angular/cli version: (if applicable) ~9.0.0-rc.6
OS: Windows 10

Link to repo showing the issus

Try to build any Angular project based on Ivy compiller

Expected Behaviour:

Compilation in Prod Successfull

Actual Behaviour:

Compilation Failed

Stack Trace/Error Message:

ERROR in ../node_modules/@angular-redux/router/lib/es5/src/index.d.ts:6:23 - error TS-996005: NgReduxRouterModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If
this occurrence is in library code you don't control, please contact the library authors.

6 static forRoot(): ModuleWithProviders;
~~~~~~~~~~~~~~~~~~~

Additional Notes:

There are need to add Generic for return type ModuleWithProviders in index.ts for NgReduxRouterModule.
Now: static forRoot(): ModuleWithProviders {
Will be: static forRoot(): ModuleWithProviders<NgReduxRouterModule> {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions